AmendHub

jcs

/

subtext

/

amendments

Amendments on July 13, 2022

sysop: Write new config but don't apply it on the fly

There are things in the idle loop that check for config settings and
we can't assume they were there at startup
jcs made amendment 201 2 months ago

Amendments on July 12, 2022

board+folder+mail: Trim trailing whitespace from fields

jcs made amendment 199 2 months ago

crc: Add explicit casting to UpdateCRC like UpdateCRC32

jcs made amendment 198 2 months ago

uthread: Bump stack size to 5K

jcs made amendment 197 2 months ago

mail+sysop+user_settings: Make menu options const

jcs made amendment 196 2 months ago

board: Make menu options const, improve prompts

jcs made amendment 195 2 months ago

telnet: Use new is_telnet session flag

jcs made amendment 193 2 months ago

signup: user_valid_username returns bool

jcs made amendment 192 2 months ago

session: A few fixes and improvements

Make session_menu a bit more helpful and hide options with a null key
set, don't repeat "Invalid option" more than once
Add session_get_char for file transfers
jcs made amendment 191 2 months ago

Amendments on July 11, 2022

zmodem: Bug fixes, remove send/recv abstraction

This doesn't really need to be portable, just call session functions
directly.
Reduce state timeouts to 10 seconds, but leave at 30 for the initial
Init state when receiving to give the user time to choose a file to
send us.
Fix IAC escaping on the way out.
jcs made amendment 189 2 months ago

telnet: When doing file transfers, fast-path to TCP buffer

We're doing IAC escaping in the zmodem code, so just move data
directly into node buffer. Also, avoid memmoving on each read since
the buffer will often have more than one byte in it, just use an
offset into ibuf and only memmove when it's over half full.
jcs made amendment 188 2 months ago

util: Fix return of FIsDir when FStat fails

jcs made amendment 187 2 months ago

zmodem: Improve debug logging, do 32-bit CRC, disable overlapping I/O

Since our output and input functions will bypass the telnet code that
escapes or unescapes IACs, add an option to do it here before
interfacing with the send/recv routines.
Interoperability testing with SyncTERM showed that it was too eager
to timeout when we didn't respond fast enough in acceping uploaded
data and writing it, so disable overlapping I/O. This way it won't
send more data to us until we've acked it.
jcs made amendment 186 2 months ago

Amendments on July 7, 2022

crc: Fix UpdateCRC32 macro, move tables into C file

The UpdateCRC32 macro needed explicit casting to fix hash generation
during ZMODEM.
jcs made amendment 183 2 months ago

Amendments on July 4, 2022

zmodem: Add BSD-licensed ZMODEM implementation from TeraTerm

Lots of internal restructuring by me to keep all state within a
zmodem_session object with callbacks to network/modem functions to
actually do the data sending and receiving.
jcs made amendment 182 3 months ago