jcs
/subtext
/amendments
Amendments on November 14, 2023
sysop: Rename old_config_data to cur_config_data
It was confusing me why we were copying new data into an "old"
struct.
Amendments on November 11, 2023
jcs made amendment
535
about 1 year ago
binkp: Check for a dead TCP connection in many places
Previously if the connection dropped in the middle of fetching, we
may have been sitting in a loop forever (though still yielding, so
it was just killing the binkp/task thread).
Amendments on November 9, 2023
jcs made amendment
533
about 1 year ago
jcs made amendment
532
about 1 year ago
*: Do config changes on the fly, restarting modules as needed
Annotate each config option with which component it needs restarted
when it changes and do those after saving from the sysop menu. This
also provides the ability to log each changed config option with its
old and new values.
jcs made amendment
530
about 1 year ago
Amendments on November 8, 2023
jcs made amendment
529
about 1 year ago
serial: Make number of rings before answering a configurable setting
Defaults to 1 as before, but can be increased to allow caller id
strings to come through the logger.
Amendments on September 20, 2023
jcs made amendment
527
about 1 year ago
jcs made amendment
526
about 1 year ago
jcs made amendment
525
about 1 year ago
jcs made amendment
524
about 1 year ago
Amendments on August 28, 2023
settings+sysop: Fix bug in settings editor that can corrupt settings
When hanging up the connection in the settings struct editor without
giving a response, session_menu returns 0, which we then returned
from struct_editor while setting new_config to NULL. Then we wrote
that NULL dereference as the new db config which trashed it :(
When the sesson is ending, make struct_editor return -1 and add an
explicit check in sysop_edit_settings to make sure the new config
isn't NULL.
db: Include AT&D2 in default modem init, we need it for hangup
This makes the modem hangup when flashing DTR and is probably the
default on real modems but we may as well be explicit about needing
it.
Amendments on August 3, 2023
session: When breaking on spaces in session_paginate, drop space
This way we're not printing spaces at the end of the line which can
cause some terminals to wrap at their width right before we print a
\r\n.
board+folder: When dynamically disabling menu options, do it by ret
Options were added to the menu in board_post_read but the array index
wasn't updated for disabling 'd', so this was disabling '>' instead.
To prevent this in the future, disable by the returned option rather
than hard-coding an index.
Amendments on August 2, 2023
session: Fix initialization of last_space in session_paginate
If the first character of the message is \r or \n, the subsequent
wrapping was wrong because last_space was still 0. Init it to -1
to properly detect when it's never been set.
session: Fix off-by-one in session_paginate
When breaking on existing newlines, this was sending the \r of \r\n
to session_output, so we were writing "line\r\r\n" which on some
terminals produced an extra blank line in between each line output.
Amendments on June 16, 2023
jcs made amendment
517
about 1 year ago