jcs
/wallops
/amendments
/95
settings+focusable: ShowWindow and then SelectWindow
Not sure why this is suddenly needed but without it, production build
crashes trying to access the window before it's visible.
jcs made amendment 95 11 months ago
--- focusable.c Thu Sep 5 10:08:39 2024
+++ focusable.c Thu Sep 12 09:53:24 2024
@@ -85,13 +85,9 @@ focusable_show(struct focusable *focusable)
}
}
- if (focusable->visible)
- SelectWindow(focusable->win);
- else {
- focusable->visible = true;
- ShowWindow(focusable->win);
- }
-
+ focusable->visible = true;
+ ShowWindow(focusable->win);
+ SelectWindow(focusable->win);
SetPort(focusable->win);
return true;
--- settings.c Wed Sep 11 13:38:54 2024
+++ settings.c Thu Sep 12 09:47:17 2024
@@ -284,6 +284,7 @@ settings_edit(bool use_defaults)
ret = false;
ShowWindow(dlg);
+ SelectWindow(dlg);
get_input:
GetDItem(dlg, ok, &itype, &ihandle, &irect);
@@ -291,6 +292,7 @@ get_input:
ModalDialog(PasswordDialogFieldFilter, &hit);
switch (hit) {
case -1:
+ goto settings_done;
case OK:
goto verify;
default: