jcs
/wallops
/amendments
/141
http: Minor safety fixes
jcs made amendment 141 about 1 month ago
--- http.c Wed Sep 25 10:13:18 2024
+++ http.c Wed Dec 17 20:09:43 2025
@@ -141,7 +141,7 @@ encode:
} else {
if (len + 3 >= dstsize)
return -1;
- sprintf((char *)dst + len, "%%%02X", c);
+ snprintf((char *)dst + len, dstsize - len, "%%%02X", c);
len += 3;
}
}
@@ -533,7 +533,7 @@ strappend(char *str, size_t str_size, size_t str_len,
if (str_len < str_size - 1)
str[str_len] = '\0';
else
- str[str_size] = '\0';
+ str[str_size - 1] = '\0';
return str_len;
}
@@ -627,6 +627,8 @@ pushover(char *api_token, char *user_key, char *option
http = http_post("http://api.pushover.net/1/messages.json",
"Content-type: application/x-www-form-urlencoded", http_body,
blen);
+ if (!http)
+ return false;
http_req_skip_headers(http);
http_req_free(&http);