jcs
/wallops
/amendments
/133
http: Make non-memory errors just return rather than throw a dialog
jcs made amendment 133 about 1 year ago
--- http.c Mon Sep 23 15:45:49 2024
+++ http.c Wed Sep 25 10:13:18 2024
@@ -196,16 +196,12 @@ http_init_req(const char *verb, const char *surl, cons
err = _TCPCreate(&req->tcp_iopb, &req->tcp_stream, (Ptr)req->tcp_buf,
req->tcp_buf_size, nil, nil, nil, false);
- if (err) {
- warn("TCPCreate failed: %d", err);
+ if (err)
goto error;
- }
err = DNSResolveName(req->url->host, &req->host_ip, NULL);
- if (err) {
- warn("Couldn't resolve host %s (%d)", req->url->host, err);
+ if (err)
goto error;
- }
long2ip(req->host_ip, (char *)&ip_s);
@@ -259,11 +255,8 @@ http_init_req(const char *verb, const char *surl, cons
err = _TCPActiveOpen(&req->tcp_iopb, req->tcp_stream, req->host_ip,
req->url->port, &local_ip, &local_port, nil, nil, false);
- if (err) {
- warn("Failed connecting to %s (%s) port %d: %d",
- req->url->host, ip_s, req->url->port, err);
+ if (err)
goto error;
- }
memset(&req->tcp_wds, 0, sizeof(req->tcp_wds));
req->tcp_wds[0].ptr = req->message;
@@ -276,10 +269,8 @@ http_init_req(const char *verb, const char *surl, cons
err = _TCPSend(&req->tcp_iopb, req->tcp_stream, req->tcp_wds, nil, nil,
false);
- if (err) {
- warn("TCPSend to %s (%s) failed: %d", req->url->host, ip_s, err);
+ if (err)
goto error;
- }
return req;