AmendHub

jcs

/

subtext

/

amendments

/

board.c

Amendments on February 5, 2023

*: Minor fixes found by cppcheck and scan-build

Mostly unused variables
jcs made amendment 300 about 1 year ago

Amendments on November 11, 2022

board: constify fields

jcs made amendment 275 about 1 year ago

Amendments on September 16, 2022

board: Store each user's 'via' in each post

I saw this on another BBS and thought it was kind of neat to see
how each person connected when they made a post.
jcs made amendment 253 about 1 year ago

Amendments on August 14, 2022

logger: Add buffered logging, support logging without updating window

During telnet negotiation, many lines are logged in quick succession
which means we spend a lot of time updating the log TextEdit. Just
buffer these logs and spit them out all at once upon login or
disconnection, so the user's login prompt is immediately responsive.
Rename session_log to session_logf while I'm in here, to reflect that
it's a format-string function.
jcs made amendment 245 about 1 year ago

Amendments on August 3, 2022

board: Fix some memory leaks, pass malloc notes to bile

jcs made amendment 232 about 1 year ago

Amendments on July 31, 2022

*: Add malloc annotations

jcs made amendment 226 about 1 year ago

Amendments on July 21, 2022

*: Use NewPtr instead of malloc, add malloc and free debugging

Instead of free(ptr), use xfree(&ptr) and after it calls
DisposePtr(ptr), it will update ptr to point at NULL to catch
use-after-frees.
When MALLOC_DEBUG is defined, each allocation is added to a
list, and removed when freed. If it's not in the list at free
time, it's a double-free. Also, instead of pointing pointers at
NULL, point them to a pre-defined block of zeroes and in the
idle loop, periodically check that this block is still zero. This
will also catch use-after-frees in a more reliable (but costly)
way.
jcs made amendment 220 about 1 year ago

Amendments on July 19, 2022

*: Add session signoff view, remove session_output_template

All remaining uses of session_output_template can use session_printf
which still does {{B}} and {{/B}} parsing.
Change session_output_view to session_output_view_or_printf to make it
easier to print a view and fallback to a string, rather than having to
check the result of session_output_view everywhere.
jcs made amendment 218 about 1 year ago

Amendments on July 16, 2022

board: Put the message index in the prompt, not the message id

It can be confusing when a user hits '1' to view the message in the
list showing "1 ..." but the prompt ends up showing "Boards:blah:4".
jcs made amendment 213 about 1 year ago

Amendments on July 15, 2022

board: Don't pre-alloc a bunch of ids in board_find_post_ids

If we return early or we return no ids, we shouldn't have a dangling
malloc(sizeof(long) * 16) that the caller might not know to free
since the count returned will be 0.
jcs made amendment 206 about 1 year ago

Amendments on July 12, 2022

board+folder+mail: Trim trailing whitespace from fields

jcs made amendment 199 about 1 year ago

board: Make menu options const, improve prompts

jcs made amendment 195 about 1 year ago

Amendments on July 4, 2022

board: Don't ask for subject on re-edit of a reply

jcs made amendment 180 about 1 year ago

Amendments on June 30, 2022

*: Hook up folders

jcs made amendment 179 about 1 year ago

Amendments on June 28, 2022

board: Fix comparison in deletion check

jcs made amendment 176 about 1 year ago

Amendments on June 22, 2022


Amendments on June 13, 2022

session: Remove session_output_string, enforce login timeout

jcs made amendment 142 about 1 year ago

Amendments on June 9, 2022

board: Support deleting posts

Depending on whether the post has replies, either delete the post or
just edit it to say it's been deleted
jcs made amendment 130 about 1 year ago

Amendments on June 7, 2022

sysop: Add user management

Also wire up new/signup login to direct there upon login, adding a
setting to the global config to allow it.
jcs made amendment 123 about 1 year ago

Amendments on June 3, 2022