jcs
/amend
/amendments
/161
committer: Move 'no changes' warn and close out of generate_diff
browser_close_committer nullifies committer but we were still touching
committer->state after generate_diff returned.
jcs made amendment 161 about 1 month ago
--- committer.c Sun Sep 27 11:28:26 2026
+++ committer.c Sun Sep 27 16:43:24 2026
@@ -197,6 +197,12 @@ committer_idle(struct focusable *focusable, EventRecor
break;
case COMMITTER_STATE_DO_DIFF:
committer_generate_diff(committer);
+ if (committer->diff_adds == 0 && committer->diff_subs == 0) {
+ if (!committer->canceled)
+ warn("No changes detected");
+ browser_close_committer(committer->browser);
+ return;
+ }
committer->state = COMMITTER_STATE_IDLE;
break;
case COMMITTER_STATE_DO_COMMIT:
@@ -495,12 +501,6 @@ done_diffing:
if (selected_files != NULL)
xfree(&selected_files);
SetCursor(&arrow);
-
- if (committer->diff_adds == 0 && committer->diff_subs == 0) {
- if (!committer->canceled)
- warn("No changes detected");
- browser_close_committer(committer->browser);
- }
}
void