jcs
/subtext
/amendments
/623
zip: Fix filename length check
jcs made amendment 623 11 months ago
--- zip.c Mon Mar 27 16:45:53 2023
+++ zip.c Thu Dec 11 20:57:24 2025
@@ -203,7 +203,7 @@ zip_read_file(Str255 path, zip_extract_decider *decide
goto read_fail;
}
fn_len = GET_U16(&buf);
- if (fn_len >= sizeof(buf)) {
+ if (fn_len >= sizeof(filename)) {
logger_printf("[zip] Filename len %d too big", fn_len);
fret = ZIP_UNSUPPORTED;
goto read_fail;
@@ -217,12 +217,6 @@ zip_read_file(Str255 path, zip_extract_decider *decide
ex_len = GET_U16(&buf);
/* filename */
- if (fn_len > sizeof(filename)) {
- logger_printf("[zip] Filename too long (%ld)", fn_len);
- fret = ZIP_UNSUPPORTED;
- goto read_fail;
- }
-
if (zip_read(frefnum, &filename, fn_len) != fn_len) {
fret = ZIP_SHORT_READ;
goto read_fail;